Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that causes feature flags to be refreshed even when there are no changes #138

Closed
abhilasharora opened this issue Mar 4, 2020 · 0 comments · Fixed by #141
Closed
Assignees
Labels
bug Something isn't working

Comments

@abhilasharora
Copy link
Contributor

Currently, when feature flags are refreshed, we first make a request to fetch the Key and ETag for all feature flags. Then we compare it to the ETag for the feature flags that are currently in the client configuration. The expected behavior is to fetch the updated values of the feature flags only if we detect a change in the 'ETag' for one or more feature flags. However, the current code has a bug where the feature flag values are being fetched even when no change is detected based on the ETag comparisons. This item tracks fixing that bug, so we make a single request instead of two requests to refresh the feature flag values when no change is detected.

@abhilasharora abhilasharora self-assigned this Mar 4, 2020
@zhenlan zhenlan added the bug Something isn't working label Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants