Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow exception for CriticalAddonsOnly taint on system nodepools (or all) #1833

Closed
palma21 opened this issue Sep 1, 2020 · 4 comments
Closed
Labels

Comments

@palma21
Copy link
Member

palma21 commented Sep 1, 2020

Follow up for #1484. To unblock automation like terraform to tag the first (and system) nodepool as well as allow for taints on all nodepools, AKS will always accept CriticalAddonsOnly

@ghost ghost added the triage label Sep 1, 2020
@Azure Azure deleted a comment Sep 1, 2020
@palma21 palma21 added feature feature-request Requested Features labels Sep 1, 2020
@ghost ghost removed the triage label Sep 1, 2020
@deepakkhetwal
Copy link

deepakkhetwal commented Sep 28, 2020

@palma21 Are we saying, Is it good to go applying - CriticalAddonsOnly taint on default created system nodepool with AKS cluster?. We are having issues right now, we are using terraform.

@palma21
Copy link
Member Author

palma21 commented Sep 29, 2020

This is the ticket to support it. Right now we block it if the taints are applied to all pools. We'll make an exception for this one so you can apply it to all pools (or just the default one)

@deepakkhetwal
Copy link

This is the ticket to support it. Right now we block it if the taints are applied to all pools. We'll make an exception for this one so you can apply it to all pools (or just the default one)

Thank you @palma21 , Is there any ETA, when this would be resolved. Appreciate if this could be resolve sooner.

@ghost
Copy link

ghost commented Nov 9, 2020

Thank you for the feature request. I'm closing this issue as this feature has shipped and it hasn't had activity for 7 days.

@ghost ghost closed this as completed Nov 9, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
@aritraghosh aritraghosh moved this to Archive (GA older than 1 month) in Azure Kubernetes Service Roadmap (Public) Jul 10, 2024
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Development

No branches or pull requests

2 participants