Skip to content

Commit 84ddc26

Browse files
authored
Merge pull request #11 from zhz0704/fix-import-issue
Fix import issue and update readme
2 parents 4934859 + a2fac48 commit 84ddc26

File tree

6 files changed

+36
-15
lines changed

6 files changed

+36
-15
lines changed

.github/workflows/node.js.yml

+1
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ jobs:
2929
node-version: ${{ matrix.node-version }}
3030
cache: 'npm'
3131
- run: npm ci --force
32+
- run: npm run build --if-present -- --isNpmBuild
3233
- run: npm run build --if-present
3334
- run: python -m pip install linkcheckmd
3435
- run: python -m linkcheckmd README.md

.github/workflows/npm-publish.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
node-version: 20
3030
registry-url: https://registry.npmjs.org/
3131
- run: npm ci --force
32-
- run: npm run build --if-present --isNpmBuild
32+
- run: npm run build --if-present -- --isNpmBuild
3333
- run: npm publish --access=public
3434
env:
3535
NODE_AUTH_TOKEN: ${{secrets.npm_token}}

README.md

+26-10
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,29 @@
1-
---
2-
page_type: sample
3-
description: A rich library of animations for use with the Azure Maps Web SDK.
4-
languages:
5-
- javascript
6-
- typescript
7-
products:
8-
- azure
9-
- azure-maps
10-
---
1+
<table style="width: 100%; border-collapse: collapse; border: 1px solid #333;">
2+
<thead>
3+
<tr>
4+
<th style="padding: 10px; border: 1px solid #333;">page_type</th>
5+
<th style="padding: 10px; border: 1px solid #333;">description</th>
6+
<th style="padding: 10px; border: 1px solid #333;">languages</th>
7+
<th style="padding: 10px; border: 1px solid #333;">products</th>
8+
</tr>
9+
</thead>
10+
<tbody>
11+
<tr>
12+
<td style="padding: 10px; border: 1px solid #333;">sample</td>
13+
<td style="padding: 10px; border: 1px solid #333;">A rich library of animations for use with the Azure Maps Web SDK.</td>
14+
<td style="padding: 10px; border: 1px solid #333;">
15+
<code>javascript</code>
16+
<br>
17+
<code>typescript</code>
18+
</td>
19+
<td style="padding: 10px; border: 1px solid #333;">
20+
<code>azure</code>
21+
<br>
22+
<code>azure-maps</code>
23+
</td>
24+
</tr>
25+
</tbody>
26+
</table>
1127

1228
# Azure Maps Animation module
1329

build/build.js

+5-1
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ let rollupError = false;
9494
let rollupInputOps, rollupOutputOps;
9595
if (!args.isNpmBuild) {
9696
// Set rollup options for browser builds.
97+
console.log("Building IIFE version");
9798
rollupInputOps = {
9899
external: ["azure-maps-control"],
99100
onwarn: rollupWarn,
@@ -120,12 +121,15 @@ let rollupError = false;
120121
}
121122
};
122123
} else {
124+
console.log("Building CommonJS version");
123125
rollupInputOps = {
124126
external: ["azure-maps-control"],
125127
onwarn: rollupWarn,
126128
input: inputPath,
127129
plugins: [
128-
nodeResolve(),
130+
nodeResolve({
131+
browser: true,
132+
}),
129133
commonjs({
130134
namedExports: namedExports
131135
})

package-lock.json

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@azure-maps/animations",
3-
"version": "0.0.2",
3+
"version": "0.0.3",
44
"description": "A module for the Azure Maps Web SDK that provides tools for animating data on the map.",
55
"keywords": [
66
"azure",

0 commit comments

Comments
 (0)