Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sumcheck loop ordering #728

Open
lucasxia01 opened this issue Sep 21, 2023 · 2 comments
Open

Sumcheck loop ordering #728

lucasxia01 opened this issue Sep 21, 2023 · 2 comments

Comments

@lucasxia01
Copy link
Contributor

Brought up in a discussion with Zac over potential slowdowns in Sumcheck.

Currently we iterate over each polynomial and for each one, we call add_scaled, which loops over the same batched_poly_unshifted and batched_poly_to_be_shifted memory over and over again. Instead, we should consider switching the order of the loops so that we iterate over the polynomial indices in the outer loop and over the polynomials in the inner loop.

@lucasxia01 lucasxia01 added enhancement New feature or request optimization and removed enhancement New feature or request labels Sep 21, 2023
@ledwards2225
Copy link
Collaborator

@lucasxia01 Is this still relevant? If so, can you clarify what part of the code this refers to?

@codygunton codygunton mentioned this issue Feb 27, 2025
7 tasks
@lucasxia01
Copy link
Contributor Author

I don't remember exactly what this is referring to. Should've attached it to a line in the code. Maybe @zac-williamson would know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants