Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vc): remove the p2p client validator callback #7963

Open
Tracked by #7681
Maddiaa0 opened this issue Aug 14, 2024 · 0 comments
Open
Tracked by #7681

chore(vc): remove the p2p client validator callback #7963

Maddiaa0 opened this issue Aug 14, 2024 · 0 comments
Labels
C-p2p Component: peer to peer C-validator Component: validator client

Comments

@Maddiaa0
Copy link
Member

Overview

In #7854, where the validator client a code organisation issue is bandaided by having the p2p client call back into the validator client whenever it receives a proposal ( in order to perform an attestation ).

This callback method makes me uncomfortable and feels like an anti pattern.
The AC of this issue is to reorganise the code to remove this callback pattern.

@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 14, 2024
@Maddiaa0 Maddiaa0 removed this from A3 Oct 2, 2024
@Maddiaa0 Maddiaa0 added the C-p2p Component: peer to peer label Oct 2, 2024
@github-project-automation github-project-automation bot moved this to Todo in A3 Oct 2, 2024
@Maddiaa0 Maddiaa0 added the C-validator Component: validator client label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-p2p Component: peer to peer C-validator Component: validator client
Projects
Status: Todo
Development

No branches or pull requests

1 participant