Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent constructor calls #3210

Closed
Tracked by #4052
LHerskind opened this issue Nov 2, 2023 · 0 comments
Closed
Tracked by #4052

Inconsistent constructor calls #3210

LHerskind opened this issue Nov 2, 2023 · 0 comments
Assignees
Labels
T-bug Type: Bug. Something is broken.

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Nov 2, 2023

When calling functions from a constructor, what works and what does not work is not consistent.

  • constructor -> public √
  • constructor -> public -> external public √
  • constructor -> private: fails with failing to find the contract deployed.
  • constructor -> external private: Fails with constructor_vk_hash doesn't match private_call_vk_hash issue
  • constructor -> private -> external private: fails with failing to find the contract deployed.

It seems like it is generally not supported to do private function calls from the constructor. This is currently making the flow of the slow update tree with access control quite funky since I cannot set any initial roles.

@github-project-automation github-project-automation bot moved this to Todo in A3 Nov 2, 2023
@LHerskind LHerskind added the T-bug Type: Bug. Something is broken. label Nov 2, 2023
@spypsy spypsy moved this from Todo to In Progress in A3 Jan 24, 2024
@spypsy spypsy moved this from In Progress to Todo in A3 Jan 30, 2024
@PhilWindle PhilWindle closed this as not planned Won't fix, can't repro, duplicate, stale Oct 27, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Oct 27, 2024
@iAmMichaelConnor iAmMichaelConnor removed this from A3 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: Bug. Something is broken.
Projects
None yet
Development

No branches or pull requests

3 participants