Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: contract class log refactor follow up & cleanup #12325

Open
MirandaWood opened this issue Feb 27, 2025 · 0 comments
Open

chore: contract class log refactor follow up & cleanup #12325

MirandaWood opened this issue Feb 27, 2025 · 0 comments
Assignees
@MirandaWood

Comments

@MirandaWood
Copy link
Contributor

From #12061:

  • Move the hashing of the contract class log to the oracle (as it was previously when we used sha hashing), since we constrain its correctness in the base rollup.
  • Rename oracle methods? (I don't know much about oracle best practices).
  • Move validate_and_silo_contract_class_log functionality and possibly rename.
  • Remove the blob check in data_retrieval now that we have no calldata.

@iAmMichaelConnor anything else specific to the PR that needs to be added?
@MirandaWood MirandaWood self-assigned this Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MirandaWood MirandaWood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MirandaWood