Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize encoding of note_type_id such that it occupies 7 bits. #10952

Closed
benesjan opened this issue Dec 23, 2024 · 1 comment · Fixed by #10951
Closed

Optimize encoding of note_type_id such that it occupies 7 bits. #10952

benesjan opened this issue Dec 23, 2024 · 1 comment · Fixed by #10951
Labels
team-fairies Nico's team

Comments

@benesjan
Copy link
Contributor

benesjan commented Dec 23, 2024 •
edited
Loading

With this PR note_type_id now fits into 7 bits but the encoding is still 32 bytes. I didn't optimize the encoding because the to_be_bytes function will go away once we serialize to fields.

Note: Started work on this in #10899 but stopped as the whole to_be_bytes func will be most likely eventually nuked.
@benesjan benesjan added the team-fairies Nico's team label Jan 21, 2025
@benesjan benesjan mentioned this issue Feb 17, 2025
Merged
@benesjan
Copy link
Contributor Author

Tackled in #10951

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team-fairies Nico's team
Projects
None yet
Milestone
No milestone
1 participant
@benesjan