From 8722af848760f46d54375d866941f2fa3fb0c6b2 Mon Sep 17 00:00:00 2001 From: benesjan Date: Thu, 9 May 2024 14:10:17 +0000 Subject: [PATCH] cleanup --- yarn-project/circuit-types/src/interfaces/pxe.ts | 2 +- yarn-project/circuit-types/src/keys/key_store.ts | 3 +-- .../circuits.js/src/contract/contract_address.test.ts | 8 -------- yarn-project/circuits.js/src/contract/contract_address.ts | 2 -- 4 files changed, 2 insertions(+), 13 deletions(-) diff --git a/yarn-project/circuit-types/src/interfaces/pxe.ts b/yarn-project/circuit-types/src/interfaces/pxe.ts index 20e6d36bbbbe..9e01820e4f79 100644 --- a/yarn-project/circuit-types/src/interfaces/pxe.ts +++ b/yarn-project/circuit-types/src/interfaces/pxe.ts @@ -1,4 +1,4 @@ -import { type AztecAddress, type CompleteAddress, type Fr, type PartialAddress, type Point } from '@aztec/circuits.js'; +import { type AztecAddress, type CompleteAddress, type Fr, type PartialAddress } from '@aztec/circuits.js'; import { type ContractArtifact } from '@aztec/foundation/abi'; import { type ContractClassWithId, type ContractInstanceWithAddress } from '@aztec/types/contracts'; import { type NodeInfo } from '@aztec/types/interfaces'; diff --git a/yarn-project/circuit-types/src/keys/key_store.ts b/yarn-project/circuit-types/src/keys/key_store.ts index e87699e1c08d..b4a0d7ce300a 100644 --- a/yarn-project/circuit-types/src/keys/key_store.ts +++ b/yarn-project/circuit-types/src/keys/key_store.ts @@ -1,10 +1,9 @@ import { - type CompleteAddress, type AztecAddress, + type CompleteAddress, type Fr, type GrumpkinPrivateKey, type PartialAddress, - type Point, type PublicKey, } from '@aztec/circuits.js'; diff --git a/yarn-project/circuits.js/src/contract/contract_address.test.ts b/yarn-project/circuits.js/src/contract/contract_address.test.ts index 6199e69a25dd..a9c10a16243c 100644 --- a/yarn-project/circuits.js/src/contract/contract_address.test.ts +++ b/yarn-project/circuits.js/src/contract/contract_address.test.ts @@ -69,14 +69,6 @@ describe('ContractAddress', () => { }).toString(); expect(address).toMatchSnapshot(); - - // TODO(#5834): the following was removed from aztec_address.nr, should it be re-introduced? - // // Run with AZTEC_GENERATE_TEST_DATA=1 to update noir test data - // updateInlineTestData( - // 'noir-projects/noir-protocol-circuits/crates/types/src/address/aztec_address.nr', - // 'expected_computed_address_from_preimage', - // address.toString(), - // ); }); it('Public key hash matches Noir', () => { diff --git a/yarn-project/circuits.js/src/contract/contract_address.ts b/yarn-project/circuits.js/src/contract/contract_address.ts index 06fecb1a1df3..11c4dade226d 100644 --- a/yarn-project/circuits.js/src/contract/contract_address.ts +++ b/yarn-project/circuits.js/src/contract/contract_address.ts @@ -10,8 +10,6 @@ import { deriveKeys } from '../keys/index.js'; // TODO(@spalladino): Review all generator indices in this file -// TODO(benesjan): NUKE? - /** * Returns the deployment address for a given contract instance as defined on the [Protocol Specs](../../../../docs/docs/protocol-specs/addresses-and-keys/specification.md). * ```