diff --git a/noir-projects/aztec-nr/aztec/src/note/note_getter/mod.nr b/noir-projects/aztec-nr/aztec/src/note/note_getter/mod.nr index 75481c9d036..560969ca198 100644 --- a/noir-projects/aztec-nr/aztec/src/note/note_getter/mod.nr +++ b/noir-projects/aztec-nr/aztec/src/note/note_getter/mod.nr @@ -20,9 +20,9 @@ fn extract_property_value_from_selector( packed_note_content: [Field; N], selector: PropertySelector, ) -> Field { - // Selectors use PropertySelectors in order to locate note properties inside the serialized note. - // This allows easier packing and custom (de)serialization schemas. A note property is located - // inside the serialized note using the index inside the array, a byte offset and a length. + // Selectors use PropertySelectors in order to locate note properties inside the packed note. + // This allows easier packing and custom (un)packing schemas. A note property is located + // inside the packed note using the index inside the array, a byte offset and a length. let value: [u8; 32] = packed_note_content[selector.index].to_be_bytes(); let offset = selector.offset; let length = selector.length; diff --git a/noir-projects/noir-contracts/contracts/ecdsa_public_key_note/src/lib.nr b/noir-projects/noir-contracts/contracts/ecdsa_public_key_note/src/lib.nr index dc81c6c3a64..2ec8c33c628 100644 --- a/noir-projects/noir-contracts/contracts/ecdsa_public_key_note/src/lib.nr +++ b/noir-projects/noir-contracts/contracts/ecdsa_public_key_note/src/lib.nr @@ -21,7 +21,7 @@ pub struct EcdsaPublicKeyNote { } impl NoteInterface for EcdsaPublicKeyNote { - // Cannot use the automatic packing since x and y don't fit. Serialize the note as 5 fields where: + // Cannot use the automatic packing since x and y don't fit. Pack the note as 5 fields where: // [0] = x[0..31] (upper bound excluded) // [1] = x[31] // [2] = y[0..31] diff --git a/noir-projects/noir-protocol-circuits/crates/types/src/meta/mod.nr b/noir-projects/noir-protocol-circuits/crates/types/src/meta/mod.nr index 5d18db735cb..5ce00c03f85 100644 --- a/noir-projects/noir-protocol-circuits/crates/types/src/meta/mod.nr +++ b/noir-projects/noir-protocol-circuits/crates/types/src/meta/mod.nr @@ -9,6 +9,8 @@ use super::traits::{Deserialize, Packable, Serialize}; /// - `num_already_consumed`: The number of fields already processed in previous recursion calls. /// - `to_replace`: The name of a specific field that should be replaced during deserialization. /// - `ro_replace_with`: The value to replace the `to_replace` field with (e.g., `NoteHeader::empty()`). +/// - `should_unpack`: A boolean indicating whether the type should be unpacked (see description of `Packable` +/// and `Serialize` trait for more information about the difference between packing and serialization). /// /// # Returns /// A tuple containing: