Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LocalizedError inheritance for thrown errors #181

Closed
AvdLee opened this issue Jul 24, 2022 · 1 comment · Fixed by #185
Closed

Add LocalizedError inheritance for thrown errors #181

AvdLee opened this issue Jul 24, 2022 · 1 comment · Fixed by #185
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@AvdLee
Copy link
Owner

AvdLee commented Jul 24, 2022

Errors for localizedDescription now only print:

AppStoreConnect_Swift_SDK.APIProvider.Error

While it should be something like:

response {
    "errors": [{
        "status": "401",
        "code": "NOT_AUTHORIZED",
        "title": "Authentication credentials are missing or invalid.",
        "detail": "Provide a properly configured and signed bearer token, and make sure that it has not expired. Learn more about Generating Tokens for API Requests https://developer.apple.com/go/?id=api-generating-tokens"
    }]
}).
@AvdLee AvdLee added enhancement New feature or request good first issue Good for newcomers labels Jul 24, 2022
@SwiftLeeBot
Copy link
Collaborator

The pull request #185 that closed this issue was merged and released as part of Release 2.1.0 🚀
Please let us know if the functionality works as expected as a reply here. If it does not, please open a new issue. Thanks!

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants