Tmds.DBus

[tmds]

hi, I'm the maintainer of Tmds.DBus.

I noticed you've cloned the library: https://github.com/AvaloniaUI/Tmds.DBus.
And from the changes I wonder if you're forking the code?

If you're forking the code, I wonder if there are changes we can make upstream, which make the fork unnecessary?

cc @kekekeks

[timunie]

I think it was done in #9810 probably. Let me add @affederaffe as he was the author of the PR.

[kekekeks]

@tmds We are concerned about Nerdbank.Streams dependency pulling way too many additional libraries. This dependency wasn't there previously in Tmds.DBus package. As a UI toolkit, we have to keep the list of dependencies minimal, we've even removed a dependency on System.Reactive because it pulls extra deps when targeting net6-windows10.

Also, we don't see why a DBus library needs System.Security.Principal.Windows dependency.

In the fork I've removed dependencies on those: https://github.com/AvaloniaUI/Tmds.DBus/commit/c6900b5b13c56a6e36462030dbeaca5865e055e8

I doubt that such changes would be accepted to the upstream, so the current plan is to include Tmds.DBus.Protocol as source code with public types made internal.

[tmds]

We are concerned about Nerdbank.Streams dependency pulling way too many additional libraries. This dependency wasn't there previously in Tmds.DBus package. As a UI toolkit, we have to keep the list of dependencies minimal, we've even removed a dependency on System.Reactive because it pulls extra deps when targeting net6-windows10.

I will take a PR that removes these dependencies.

Also, we don't see why a DBus library needs System.Security.Principal.Windows dependency.

I'll take a look into this one.

[tmds]

Also, we don't see why a DBus library needs System.Security.Principal.Windows dependency.

This is fixed by tmds/Tmds.DBus#186.

[maxkatz6]

@tmds I have a recommendation. Instead of RuntimeInformation.IsOSPlatform(OSPlatform.Windows) it's better to use OperatingSystem.IsWindows() (available starting net6).
This way, .NET compiler will be able to trim this whole dependency (which is still referenced but implicitly now) on non-windows runtime identifiers.

[tmds]

Thanks for the recommendation, I didn't know that. I've adopted it here: tmds/Tmds.DBus#187.

[tmds]

@kekekeks can you make a PR with your change that removes the dependency on Nerdbank.Streams and its dependencies?

[maxkatz6]

@tmds done tmds/Tmds.DBus#189

[tmds]

The desired changes are now available on the 0.14.0 version which I've just uploaded to nuget.org.