fix(api-core): resources incorrectly handling config

some resources could not handle undefined config providers would throw away any passed in params in config
Availity · Jan 4, 2018 · 9a5de1c · 9a5de1c
1 parent 2443bc0
commit 9a5de1c
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/packages/api-core/src/resources/organizations.js b/packages/api-core/src/resources/organizations.js
@@ -19,8 +19,9 @@ export default class AvOrganizations extends AvApi {
   }
 
   queryOrganizations(user, config) {
-    const params = Object.assign({}, { userId: user.id }, config.params || {});
-    return this.query(Object.assign({}, { params }, config));
+    const queryConfig = Object.assign({ params: {} }, config);
+    queryConfig.params = Object.assign({ userId: user.id }, queryConfig.params);
+    return this.query(queryConfig);
   }
 
   getOrganizations(config) {

diff --git a/packages/api-core/src/resources/providers.js b/packages/api-core/src/resources/providers.js
@@ -12,14 +12,10 @@ export default class AvProviders extends AvApi {
     super(http, promise, options);
   }
 
-  getProviders(customerId, config = {}) {
-    let queryConfig = {
-      params: {
-        customerId,
-      },
-    };
+  getProviders(customerId, config) {
+    const queryConfig = Object.assign({ params: {} }, config);
+    queryConfig.params = Object.assign({ customerId }, queryConfig.params);
 
-    queryConfig = Object.assign({}, queryConfig, config);
     return this.query(queryConfig);
   }
 }
diff --git a/packages/api-core/src/resources/regions.js b/packages/api-core/src/resources/regions.js
@@ -22,9 +22,12 @@ export default class AvRegions extends AvApi {
 
   getRegions(config) {
     return this.avUsers.me().then(user => {
-      config.params = config.params || {};
-      config.params.userId = config.params.userId || user.id;
-      return this.query(config);
+      const queryConfig = Object.assign({ params: {} }, config);
+      queryConfig.params = Object.assign(
+        { userId: user.id },
+        queryConfig.params
+      );
+      return this.query(queryConfig);
     });
   }