Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row block width setting acts different based on the images' width settings before added. #76441

Closed
csabarakasz opened this issue Apr 30, 2023 · 3 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Platform] Atomic [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@csabarakasz
Copy link

csabarakasz commented Apr 30, 2023

Quick summary

While troubleshooting a user's site (6214926-zd-woothemes), I noticed a weird behavior with images inside a Row block.

Based on the settings before the image was added to the Row block, it will look different on the live site, even though in the editor they have the same settings.

Steps to reproduce

  1. Create a new page with two images added.
  2. Image 1, add Full width adjustment.
  3. Image 2, leave the width adjustment on None.
  4. Add both images into their own Row block.
  5. Set the Row block to Full Width
  6. The image that already had the Full Width settings before will look full width on the live site. The image that did not have full width before will have a padding on the Row block, even though it is set to Full Width.
c2jAtZYDhrbcvd53nWAxLHcPpGmnYl5SYhOP4IEX.mp4

What you expected to happen

The Row block full width setting would work either way.

What actually happened

It doesn't act that way.

Impact

All

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

No response

Logs or notes

I tested it on a Premium plan site with the Dorna theme, the user's original theme, but it can be replicated on 2023 as well.

Workaround

Remove the image from the Row block. Change the width settings to Full Width, re-add the image to the Row block. Or remove the Padding on the Row block.

@csabarakasz csabarakasz added [Type] Bug When a feature is broken and / or not performing as intended User Report labels Apr 30, 2023
@github-actions github-actions bot added the [Pri] Normal Schedule for the next available opportuinity. label Apr 30, 2023
@github-actions
Copy link

Support References

This comment is automatically generated. Please do not edit it.

  • 6214926-zen

@cuemarie
Copy link

cuemarie commented May 2, 2023

📌 SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

📌 FINDINGS/SCREENSHOTS/VIDEO

  • Replicated in Simple, AT, and Self-hosted, using theme Twenty Twenty-Three:

Self-Hosted specifics:
- WordPress 6.2
- Gutenberg Version 15.6.2
- All other plugins inactive

When an Image block is placed inside a Row or Stack, it's own Align Controls are removed from the toolbar. However, if the image is placed inside a Group block, the Align controls of the image block are available. This is likely on purpose (thinking of WordPress/gutenberg#40059 (comment) ), but the alignment of the image prior to grouping is impacting the behavior of the block after grouping, as reported in this issue.

jZu2dd.mp4

Screenshots/Recordings

Self-Hosted

cCtdRR.mp4

📌 ACTIONS

  • Assigned to Cylon

@mrfoxtalbot
Copy link

This has been fixed in core.

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Platform] Atomic [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

4 participants