Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full Site Editing: Improve Block settings hiding logic on Template block selection #35608

Closed
Copons opened this issue Aug 20, 2019 · 0 comments · Fixed by #35614
Closed

Full Site Editing: Improve Block settings hiding logic on Template block selection #35608

Copons opened this issue Aug 20, 2019 · 0 comments · Fixed by #35614
Assignees
@Copons
Labels
[Goal] Full Site Editing [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@Copons
Copy link
Contributor

Copons commented Aug 20, 2019

#35387 introduced a setInterval approach to hide the Block settings sidebar when the Template block is selected.
It works, but we might be able to achieve the same effect in a cleaner way, using the Gutenberg store instead.

See conversation: #35387 (comment)
@Copons Copons added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Goal] Full Site Editing labels Aug 20, 2019
@Copons Copons self-assigned this Aug 20, 2019
@Copons Copons mentioned this issue Aug 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Copons Copons

Labels
[Goal] Full Site Editing [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Full Site Editing: Disable the Block sidebar when a Template block is selected Automattic/wp-calypso
1 participant
@Copons