Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSE: It's difficult to understand how to edit the site tagline. #35421

Closed
apeatling opened this issue Aug 15, 2019 · 7 comments
Closed

FSE: It's difficult to understand how to edit the site tagline. #35421

apeatling opened this issue Aug 15, 2019 · 7 comments
Assignees
Labels
[Goal] Full Site Editing [Pri] High Address as soon as possible after BLOCKER issues [Type] Bug When a feature is broken and / or not performing as intended

Comments

@apeatling
Copy link
Member

Via @ianstewart

I wasn't able to edit the "Site Description" text with a double-click followed by typing, unlike almost all other text on the screen.

@apeatling apeatling added [Type] Bug When a feature is broken and / or not performing as intended [Pri] Normal Schedule for the next available opportuinity. [Goal] Full Site Editing labels Aug 15, 2019
@noahtallen
Copy link
Contributor

I was unable to reproduce this bug in the current version - though sometimes the "plus" icon for adding a block overlays the bottom part of the description. We also added more actionable text and a clearer UI in #35364, which should help people understand how to edit it better!

@apeatling apeatling added [Pri] High Address as soon as possible after BLOCKER issues and removed [Pri] Normal Schedule for the next available opportuinity. labels Aug 15, 2019
@glendaviesnz
Copy link
Contributor

glendaviesnz commented Aug 15, 2019

probably is related to Add Block button as this is also noted here p58i-7YJ-p2 - will take a look and see if we can move placement of this

@glendaviesnz
Copy link
Contributor

Part of the fix at Automattic/themes#1269 which moves the add block button to the right to stop it conflicting with trying to select the centred text (couldn't see any other way around this).

Will take a look at the double click issue separately.

@glendaviesnz
Copy link
Contributor

glendaviesnz commented Aug 16, 2019

@apeatling Have spent a bit of time looking at this double click to select issue. The problem is that double click to select and start typing only works if you are in the text area and have the 'text' cursor:

Screen Shot 2019-08-16 at 4 01 35 PM

This is the same as with all the other blocks - eg. in the paragraph block if you double click at the edges of the block where you have the pointer cursor instead of text cursor it doesn't work either.

The problem we have is that in order to get the layout matching the frontend we have wound back the margins and text area widths, so in the Site Title and Site Description blocks there is very little surface area where you get the text cursor.

Not sure on the best way to solve this issue. Will keep thinking, and maybe someone else on the team may have some ideas tomorrow.

@carinapilar
Copy link

I was able to replicate this before having an image set on that next Image block. As shown on this screencast:

SiteDescription

@noahtallen
Copy link
Contributor

I wonder if some of this will be helped by #35387...

@Copons
Copy link
Contributor

Copons commented Aug 20, 2019

As already mentioned #35387 will fix this by restoring the original blocks margin, leaving enough space for the insert button (and hover area) which was covering the previous blocks.

Aug-20-2019 12-24-50

cc @ianstewart @carinapilar

@Copons Copons closed this as completed Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] Full Site Editing [Pri] High Address as soon as possible after BLOCKER issues [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

5 participants