Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap babel/polyfill to wp-polyfill for Slideshow block #31689

Closed
simison opened this issue Mar 22, 2019 · 1 comment · Fixed by Automattic/jetpack#11657 or #31690
Closed

Swap babel/polyfill to wp-polyfill for Slideshow block #31689

simison opened this issue Mar 22, 2019 · 1 comment · Fixed by Automattic/jetpack#11657 or #31690
Assignees
@simison
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Pri] Normal Schedule for the next available opportuinity. Slideshow [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@simison
Copy link
Member

simison commented Mar 22, 2019

Instead of importing Babel-polyfill in Slideshow block:

wp-calypso/packages/jetpack-blocks/src/blocks/slideshow/create-swiper.js

Line 5 in 5084aac

import '@babel/polyfill';

We can enqueue wp-polyfill here:

https://github.com/Automattic/jetpack/blob/11ce14e6981c36127d07e21b12c00fb77a11b752/extensions/blocks/slideshow/slideshow.php#L26-L28

See tiled gallery for example:

https://github.com/Automattic/jetpack/blob/11ce14e6981c36127d07e21b12c00fb77a11b752/extensions/blocks/tiled-gallery/tiled-gallery.php#L32

Background convo:

#31228 (comment)

Automattic/jetpack#11487

p1553269980124300-slack-jetpack-gutenberg
@simison simison added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Goal] Gutenberg Working towards full integration with Gutenberg Slideshow labels Mar 22, 2019
This was referenced Mar 22, 2019
Merged
Merged
@simison
Copy link
Member Author

simison commented Mar 22, 2019 •
edited
Loading

Jetpack: Automattic/jetpack#11657
Calypso: #31690
wpcom D25931-code

@simison simison added [Pri] Normal Schedule for the next available opportuinity. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simison simison

Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Pri] Normal Schedule for the next available opportuinity. Slideshow [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
2 participants
@simison @sirreal