Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Puppeteer Issue with E2E tests #1245

Closed
dmallory42 opened this issue Jan 26, 2021 · 2 comments
Closed

Fix Puppeteer Issue with E2E tests #1245

dmallory42 opened this issue Jan 26, 2021 · 2 comments
Labels
category: devops Features and tools supporting dev process. category: e2e Issues and PRs related to e2e tests. good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. needs prioritisation Triage finished and issues are ready for the following processing. size: small The issue is sized small.

Comments

@dmallory42
Copy link
Contributor

dmallory42 commented Jan 26, 2021 •
edited
Loading

It seems that occasionally, the E2E tests can fail with the following error message:

Error: Cannot find module 'puppeteer'

This is seemingly related to WordPress/wordpress-develop#347 (comment) and can be fixed by adding the alias used by wp-scripts. Upon doing this, a further issue occurs related to puppeteer not being able to find the correct build of Chromium. The only way to then resolve this and get the E2E tests working is to delete package-lock.json and node_modules/ and re-install with npm ci, followed by npm install.

We should look into implementing this fix, which should prevent this issue from happening again: WordPress/wordpress-develop@a931153
@dmallory42 dmallory42 added category: e2e Issues and PRs related to e2e tests. size: small The issue is sized small. good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. labels Apr 7, 2021
@vbelolapotkov vbelolapotkov added the category: devops Features and tools supporting dev process. label Dec 28, 2021
@jessy-p jessy-p added the needs prioritisation Triage finished and issues are ready for the following processing. label Feb 4, 2022
@alefesouza
Copy link
Member

I couldn't replicate it on my machine, I believe that it was fixed and the issue wasn't closed, could someone else test it?

@jessy-p
Copy link
Contributor

jessy-p commented Mar 7, 2022

Yes, this seems to be working fine now. Closing

@jessy-p jessy-p closed this as completed Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: devops Features and tools supporting dev process. category: e2e Issues and PRs related to e2e tests. good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. needs prioritisation Triage finished and issues are ready for the following processing. size: small The issue is sized small.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alefesouza @vbelolapotkov @dmallory42 @jessy-p