Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lessons subheading is too small in Course Outline block #7085

Closed
merkushin opened this issue May 4, 2023 · 1 comment · Fixed by Automattic/sensei#7068
Closed

Lessons subheading is too small in Course Outline block #7085

merkushin opened this issue May 4, 2023 · 1 comment · Fixed by Automattic/sensei#7068

Comments

@merkushin
Copy link
Member

merkushin commented May 4, 2023

There are a few requests from users that the "Lessons" subheading in the course outline is too small.
At the same time, it is impossible to customize the size of that subheading through Site Editor.

Steps to Reproduce

  1. Create a course with modules and lessons.
  2. Go to the frontend and open the course outline.

What I Expected

"Lessons" subheading is readable.

What Happened Instead

Subheading is too small.

PHP / WordPress / Sensei LMS version

7.2/6.2/4.13.1

Screenshot / Video

image
image

Context / Source

p1682995692800859-slack-C02P7FHLVR9
6254780-zd-woothemes

Possible Solution

We could easily bump it up to 20px, and increase the padding top & bottom to 10px, instead of 5 right now.

p1683015371488429/1682995692.800859-slack-C02P7FHLVR9

This should be done across all theme variations.

Note:
We should be careful not to make the "Lessons" text bigger than the name of the module. For example, the module name for the Blue variation has a font size of 19.8px, so changing "Lessons" text to 20px would make it larger than the module, which is not what we want. Given this, we'll likely need to bump the font size of the module proportionally as well.

@merkushin merkushin added the [Type] Bug Something isn't working label May 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Support References

This comment is automatically generated. Please do not edit it.

  • 6254780-zen

@donnapep donnapep transferred this issue from Automattic/sensei May 18, 2023
@donnapep donnapep changed the title Lessons subheading is too small Lessons subheading is too small in Course Outline block May 18, 2023
@donnapep donnapep added [Pri] Low and removed [Pri] TBD [Type] Bug Something isn't working labels May 18, 2023
@donnapep donnapep added this to the Course - 1.3.1 milestone Jun 20, 2023
@Imran92 Imran92 self-assigned this Aug 8, 2023
@donnapep donnapep modified the milestones: Course - 1.3.1, Course 1.3.2 Aug 9, 2023
@donnapep donnapep modified the milestones: Course 1.3.3, Course 1.3.4 Sep 12, 2023
@donnapep donnapep modified the milestones: Course 1.3.4, Course 1.3.5 Oct 14, 2023
@donnapep donnapep modified the milestones: Course 1.3.5, Course 1.3.6 Oct 31, 2023
@Imran92 Imran92 self-assigned this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants