Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pym_id attribute to the shortcode to allow custom ID names #21

Closed
benlk opened this issue Apr 3, 2017 · 1 comment
Closed

Add pym_id attribute to the shortcode to allow custom ID names #21

benlk opened this issue Apr 3, 2017 · 1 comment
Labels
priority: low type: feature request type: improvement

Comments

@benlk
Copy link
Collaborator

benlk commented Apr 3, 2017 •
edited
Loading

This grows out of #20:

We should probably make a new pym_id parameter on the shortcode that allows end users to configure the ID of the generated embed on the page.

https://github.com/INN/pym-shortcode/blob/master/pym-shortcode.php#L54 would change to something like:

( isset( $atts['pym_id'] ) ) ? $atts['pym_id'] : "pym_$pym_id" ,
@benlk benlk mentioned this issue Apr 5, 2017
Closed
@benlk benlk mentioned this issue May 18, 2017
Merged
@benlk
Copy link
Collaborator Author

benlk commented Jun 23, 2017

#25 added an id="" attribute

@benlk benlk closed this as completed Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: low type: feature request type: improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benlk