Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden post type usage #33

Closed
dkoo opened this issue Feb 18, 2021 · 3 comments · Fixed by #43
Closed

Harden post type usage #33

dkoo opened this issue Feb 18, 2021 · 3 comments · Fixed by #43
Assignees
Labels
enhancement New feature or request released on @alpha

Comments

@dkoo
Copy link
Contributor

dkoo commented Feb 18, 2021

We built Newspack Listings to be flexible in the usage of the various listing types, but in order to more easily cross-reference listings with each other and other content types, we should more clearly define the use cases for Places and Marketplace listings: businesses should always be represented as places, and Marketplace listings as one-off pieces of content. This would make it easier for us to create a parent-child relationship between businesses as Places and the Marketplace listings they own.

If we did this, Places would become the de facto content type that publishers sell to third parties to represent their business, and Marketplace listings would be the content that those third parties could create and edit on their own. Marketplace listings could also serve as classified ads and obituaries, and we would offer block pattern layouts for all of these use cases, while removing the Business patterns from the Marketplace post type.

We could also create a similar parent-child relationship between Places and Events, so that (for example) a concert venue could be created as a Place, and Event listings that take place at the venue could be associated with it. Porting ideas from #22 here (not vetted, just ideas):

  • If a Place is added to an Event as a venue, when viewing the Event's single page, you should see some info on the venue appear automatically below the content.
  • If that Event is added to a list with map functionality enabled, its venue's location data should be added to the map (as well as any map data existing in the Event post content itself).
  • If viewing a Place that is attached to one or more Events, you should be able to see a list of the Events below the content.
@dkoo dkoo added this to the Phase 2 milestone Feb 18, 2021
@dkoo
Copy link
Contributor Author

dkoo commented Feb 18, 2021

Another aspect of this feature is to be able to associate Marketplace and Event listings with Places. For Marketplace/Event CPTs, we should show a sidebar panel that lets you search for and choose one or more Places to "own" the listing.

@dkoo dkoo added the enhancement New feature or request label Feb 18, 2021
@dkoo dkoo self-assigned this Feb 18, 2021
@dkoo
Copy link
Contributor Author

dkoo commented Feb 25, 2021

I think we can handle this with shadow taxonomies like we do with Newspack Sponsors. A taxonomy with shadow terms can be registered for Place posts, and those terms can be applied to Marketplace or Event listings.

We could potentially use this same method to register shadow taxonomies for each listing type that can be applied to regular posts and pages to address #34, too.

@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 2.0.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released on @alpha
Projects
None yet
2 participants