Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing Doc (mmapv1 deprecated in mongodb 4.2) #9529

Closed
FlameFractal opened this issue Nov 8, 2020 · 1 comment
Closed

Contributing Doc (mmapv1 deprecated in mongodb 4.2) #9529

FlameFractal opened this issue Nov 8, 2020 · 1 comment
Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Milestone

Comments

@FlameFractal
Copy link

Do you want to request a feature or report a bug?

Documentation fix

What is the current behavior?

CONTRIBUTING.md states

- start a mongodb instance on port 27017 if one isn't running already. `mongod --dbpath <path to store data> --port 27017 --storageEngine mmapv1`. Mongoose tests run much faster on the mmapv1 storage engine as opposed to the WiredTiger storage engine.

As mmapv1 has been removed in MongoDB 4.2, starting the server with the command in the doc gives error Cannot start server with an unknown storage engine: mmapv1

We should probably update the doc to reflect the same.

@vkarpov15
Copy link
Collaborator

Will do. We did a lot of work to make Mongoose tests not create too many collections: rapidly creating and dropping collections makes WiredTiger grind to a halt. Right now we typically run tests locally using the inMemory storage engine on MongoDB enterprise.

@vkarpov15 vkarpov15 added this to the 5.10.14 milestone Nov 10, 2020
@vkarpov15 vkarpov15 added the docs This issue is due to a mistake or omission in the mongoosejs.com documentation label Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Projects
None yet
Development

No branches or pull requests

2 participants