Generic typing does not cover more than the first level

[DIEGOHORVATTI]

Well, let's look at the problem: if I have to insert data into moongose ​​as an object, even passing the desired type as generic, when the data is an object, it does not check each of the items, validating its typing and even name

Example

import { Schema } from 'mongoose'

interface IUser {
  name: string
  reasons: {
    inactivation: string
    activation: string
    analysis: string
  }
}

// First level of hierarchy
const schema1 = new Schema<IUser>(
  {
    name: { type: Number, required: true },// Error: Type 'Number' is not assignable to type 'String'.
    reasons: {
      inactivation: { type: Number }, // No error
      activation: { type: String },
      analysis: { type: String }
    }
})

// From the second level of hierarchy
const schema2 = new Schema<IUser>(
  {
    name: { type: String, required: true }, 
    reasons: {
      inactiXXXXvation: { type: Number }, // No error
      activation: { type: String },
      analysis: { type: String }
    }
})

Well for now I solved it as follows

import { type SchemaDefinitionProperty } from 'mongoose'

type ExtractRequired<Composition, K extends keyof Composition> = Required<NonNullable<Composition[K]>>

export declare global {
  type SchemaFactoryProps<Composition, ExtraInfo = unknown> = {
    [K in keyof Composition]-?: SchemaDefinitionProperty<ExtractRequired<Composition, K>>
  }
}

import { Schema } from 'mongoose'

interface IUser {
  name: string
  reasons: {
    inactivation: string
    activation: string
    analysis: string
  }
}

const schema1 = new Schema<IUser>({
  name: { type: String, required: true },
  reasons: {
    inactiXXvation: { type: String }, // Error: Object literal may only specify known properties, but 'inactiXXvation' does not exist in type 'SchemaFactoryProps<{ inactivation: string; activation: string; analysis: string; }, unknown>'. Did you mean to write 'inactivation'?
    activation: { type: String },
    analysis: { type: String }
  } satisfies SchemaFactoryProps<IUser['reasons']>
})

const schema2 = new Schema<IUser>({
  name: { type: String, required: true },
  reasons: {
    inactivation: { type: Number }, // Error: Type 'Number' is not assignable to type 'String'. inactivation: SchemaDefinitionProperty<string>
    activation: { type: String },
    analysis: { type: String }
  } satisfies SchemaFactoryProps<IUser['reasons']>
})

Every time I have a new object I do the satisfaction again, does anyone have a better way around this?

[vkarpov15]

How about the following? Still requires some code changes, but certainly less verbose.

import { Schema } from 'mongoose'

interface IUser {
  name: string
  reasons: {
    inactivation: string
    activation: string
    analysis: string
  }
}

// First level of hierarchy
const schema1 = new Schema<IUser>(
  {
    name: { type: Number, required: true },// Error: Type 'Number' is not assignable to type 'String'.
    reasons: new Schema<IUser['reasons']>({
      inactivation: { type: Number, required: true }, // Type '{ type: NumberConstructor; required: true; }' is not assignable to type 'SchemaDefinitionProperty<string, { inactivation: string; activation: string; analysis: string; }> | undefined'
      activation: { type: String },
      analysis: { type: String }
    })
})

// From the second level of hierarchy
const schema2 = new Schema<IUser>(
  {
    name: { type: String, required: true }, 
    reasons: new Schema<IUser['reasons']>({
      inactiXXXXvation: { type: Number }, // Object literal may only specify known properties...
      activation: { type: String },
      analysis: { type: String }
    })
})

[DIEGOHORVATTI]

@vkarpov15 You know, it would even be possible to do this, type with recursion, but I don't know if the community would approve

[vkarpov15]

I'm sure it is possible, but I don't think it's a priority currently.

[DIEGOHORVATTI]

I'm sure it is possible, but I don't think it's a priority currently.

@vkarpov15 being a valid idea I can take responsibility for doing it

[DIEGOHORVATTI]

For me, typing is like my first testing interface

[vkarpov15]

If you want to give it a shot, go for it. Make a PR against master branch and make sure npm run test-tsd passes.