Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastify: upgrade 4.28.0 -> 5.2.1 #38

Merged
merged 2 commits into from
Jan 6, 2025
Merged

fastify: upgrade 4.28.0 -> 5.2.1 #38

merged 2 commits into from
Jan 6, 2025

Conversation

mreishus
Copy link
Contributor

@mreishus mreishus commented Jan 3, 2025

Upgrade Fastify from v4 to v5

This PR upgrades Fastify to version 5. After reviewing our codebase against the official migration guide, no code changes were required because:

  1. We're already running on Node.js v20 (Fastify v5 requirement)

  2. Our codebase doesn't use any deprecated Fastify v4 features:

    • Our route handlers use consistent async/await and promise patterns
    • We don't use any deprecated request/reply properties
    • Our .listen() calls already use the new object-based signature
    • We don't use schema validation features that would require updates
  3. Our current usage patterns are compatible with v5:

    • Simple logger configuration using boolean values
    • Standard request properties (request.query, request.headers)
    • Standard reply methods (reply.code(), reply.header(), reply.send())
    • GET and OPTIONS routes only (no affected DELETE routes)

Test/Verify

npm install, then npm test or npm start and testing all existing endpoints:

  • / (index)
  • /health-check
  • /file
  • /get

@mreishus mreishus self-assigned this Jan 3, 2025
@mreishus mreishus changed the title fastify: upgrade 4.28.0 -> 5.2.0 fastify: upgrade 4.28.0 -> 5.2.1 Jan 6, 2025
@mreishus mreishus merged commit 6970b6c into trunk Jan 6, 2025
1 check passed
@mreishus mreishus deleted the update/fastify branch January 6, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant