Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg extensions: visual regressions in Gutenberg 6.5 (=WP 5.3) #13618

Closed
5 tasks done
simison opened this issue Oct 2, 2019 · 7 comments
Closed
5 tasks done

Gutenberg extensions: visual regressions in Gutenberg 6.5 (=WP 5.3) #13618

simison opened this issue Oct 2, 2019 · 7 comments
Assignees
Labels
Epic Formerly "Primary Issue", or "Master Issue" [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Status] Needs Design Review Design has been added. Needs a review! [Type] Bug When a feature is broken and / or not performing as intended
Milestone

Comments

@simison
Copy link
Member

simison commented Oct 2, 2019

I'm using Gutenberg 6.5 plugin on WP 5.2 to test, which should be pretty close to WP 5.3 block editor.

Using TwentyNineteen theme and Chrome browser to test. Back to the theme might be a handy tool if you need to test several default themes.

I didn't test WordAds, VideoPress, Publicize, Likes&Sharing, short url.

Regressions with Gutenberg 6.5

Gif

Screenshot 2019-10-02 at 09 11 12

Screenshot 2019-10-02 at 09 10 55

Form

Before
Screenshot 2019-10-02 at 09 27 38

After
Screenshot 2019-10-02 at 09 23 14

All blocks

Support reference links are now out of place in block previews:

Screenshot 2019-10-02 at 09 15 30

The description field should really be just text and the support link should be in its own panel. I had a proposal to standardize it but never found time to finish it: WordPress/gutenberg#11330. See also Automattic/wp-calypso#28416

Regressions unrelated to Gutenberg v6.5/WP 5.3 but I'll list here anyway

Might be related to previous updates or updates in themes also theme updates, didn't investigate:

Map

Screenshot 2019-10-02 at 09 10 24

Screenshot 2019-10-02 at 09 25 18

Tiled gallery

Screenshot 2019-10-02 at 09 21 49

Business hour

Align issues:
Screenshot 2019-10-02 at 09 20 58

Repeat visitor

Tiny text:

Screenshot 2019-10-02 at 09 19 58

cc @MichaelArestad @joanrho
cc @kwight as these might be bugs also on wpcom.

@simison simison added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Design Review Design has been added. Needs a review! [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Oct 2, 2019
@simison simison added this to the 7.9 milestone Oct 2, 2019
@kwight
Copy link
Contributor

kwight commented Oct 2, 2019

@simison Yep, a quick sampling of a bunch of them show them to be issues on WP.com as well (generally, any issue for dotorg will an issue for us too, since we're just iframing the wp-admin view anyways). Thanks for the heads-up 👍

@kwight
Copy link
Contributor

kwight commented Oct 2, 2019

Added this to our backlog just for visibility.

@joanrho
Copy link
Contributor

joanrho commented Oct 2, 2019

@simison This is really awesome and overlaps with several things we caught as well. Can I ask you to please separate each out as an issue so it's easier to address each one rather than grouping everything in one issue?

@simison
Copy link
Member Author

simison commented Oct 4, 2019

@joanrho Yo! Thanks for splitting the issues! I'm just slow. :-)

@simison simison added the Epic Formerly "Primary Issue", or "Master Issue" label Oct 4, 2019
@joanrho
Copy link
Contributor

joanrho commented Oct 4, 2019

@simison No problem, just trying to help move things along. Hope you don't mind I also just edited your main post above to include #13645 (Increasing blue notice text size) as a checked off item that's been addressed (already merged).

@MichaelArestad
Copy link
Contributor

Donezo

@simison
Copy link
Member Author

simison commented Oct 9, 2019

Nicely done, @MichaelArestad @joanrho !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Formerly "Primary Issue", or "Master Issue" [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Status] Needs Design Review Design has been added. Needs a review! [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

4 participants