Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contact Form: Form Block doesn't retain custom Button Color Settings on remount #12286

Closed
fabiankaegy opened this issue May 7, 2019 · 4 comments
Closed

Contact Form: Form Block doesn't retain custom Button Color Settings on remount #12286

fabiankaegy opened this issue May 7, 2019 · 4 comments
Assignees
@pento
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Contact Form [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Milestone
7.9

Comments

@fabiankaegy
Copy link

fabiankaegy commented May 7, 2019 •
edited by simison
Loading

Steps to reproduce

  1. Navigate to a Gutenberg Editor page and add the Form Block
  2. Enter an Email Adress and Subject Line
  3. Submit these
  4. Click on the Submit button and change the color of the button
  5. Save / Publish the Page
  6. Reload the Editor page

What I expected

The expected behaviour would be, that the form would mount right back to the block view where you see all the fields you setup, including the custom color.

What happened instead

On remounting the editor displayed the initial screen again. Once you click add form again all the fields you previously setup are still there, but the submit button loses its custom color.

Browser / OS version

macOS 10.14.4
Safari 12.1
WordPress 5.1.1
Jetpack 7.2.1
Gutenberg 5.6.1

Screenshot / Video

https://youtu.be/p-723vG3Ufs

screenshot

#user-report
@jeherve jeherve added [Feature] Contact Form [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended labels May 7, 2019
@jeherve jeherve changed the title Form Block doesn't retain custom Button Color Settings on remount Contact Form: Form Block doesn't retain custom Button Color Settings on remount May 7, 2019
@mrfoxtalbot
Copy link

The same happens when changing the label of the "Submit" button, It will revert to the default label.

@jeherve jeherve mentioned this issue Aug 21, 2019
Closed
@jeherve
Copy link
Member

jeherve commented Aug 21, 2019

Also in 2290075-zen

@matticbot matticbot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" label Aug 21, 2019
@sdixon194
Copy link
Contributor

Another in 2307507-zen

@pento pento mentioned this issue Oct 16, 2019
Merged
@jeherve jeherve added this to the 7.9 milestone Oct 16, 2019
@jeherve
Copy link
Member

jeherve commented Oct 25, 2019

Fixed in #13745

@jeherve jeherve closed this as completed Oct 25, 2019
@jeherve jeherve mentioned this issue Oct 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pento pento

Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Contact Form [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
7.9
Development

No branches or pull requests
6 participants
@pento @jeherve @mrfoxtalbot @matticbot @fabiankaegy @sdixon194