-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link in Bio (Ose Maiko) #245
Comments
This one has a bit of an identity crisis. It was supposed to be a musician's pattern, and I had a nice album artwork in the design, but I'm struggling to find good content to use as the embed. I'm also unsure if using content from someone unaffiliated with us would be ok. For now, the content is Matt's podcast, but it's not a musician and doesn't go with the title. Or maybe we include the embed in the pattern, but don't supply a specific URL and leave it in an empty state? Any help with the content would be much appreciated! cc @that-mike-bal |
@alaczek you can use this https://open.spotify.com/track/2vNw3NLCwUc0Qe9Q4fs8vE?si=de5efa7c0e384cb6 which is one of @eeeeevon13 's songs or you can use one of these that are bands/albums I play on https://open.spotify.com/album/79PCWtOG7EcbMtsSKEoCU2?si=lPb7VpAQSYSGe5M-y3W0_g or https://open.spotify.com/track/0LaT1L3kAZHYL6mXXX6lqy?si=f865d8b79a904d43 |
I've been playing with this, and came to the conclusion, that putting in an empty embed would be the most user-friendly in this case - this way we're removing the friction of customers having to figure out how to swap out the media. I also swapped Spotify embed for a generic one - that way whatever link is thrown at it should work. This is how it will look like in the inserter: The buttons in the original design had icons on them, and I figured I could achieve it via row block, the same way as in #251 BUT that means we'd run into the same issue in the editor. Using row block instead of buttons makes it also look a bit better on mobile, so I'm on the fence. |
@iamtakashi what do you think about this? |
Sorry for being late on responce after being AFK. I sort of leaning towards embeding Spotify here so it adds a context and exhibits a usecase. If this was a boilerplate pattern, my opinion would be totally different, but in my mind, the patterns in the inserter is more about showing a specific usecase. than providing a "shell or boilerplate". In terms of icon, although the icons make it the charactalistic of Link in bio site, but Gutenberg doesn't seem to be ready for it, and I personally don't like the workaround using a group block for the reason that have been said already. |
Preview: https://dotcompatterns.wordpress.com/?p=5833&preview=true
The text was updated successfully, but these errors were encountered: