-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centered header #210
Comments
I think It'd be helpful for users to see the placeholder-looking logo for a header pattern like this. Can we add this image as the logo in the pattern? https://headerandfooterpatterns.files.wordpress.com/2022/01/ba5d5-site-logo.png |
Hmm... I'm actually not sure if adding a site logo to dotcompatterns through this pattern will actually help anything. Will it be blank for the site that doesn't have a logo anyway? I guess it's worth testing with this? :) |
+1 on this. I think we need to tinker on ways to demo content in patterns even if they're WP db based(content showing up only if you have logo/post/nav on your site etc). |
It's not possible as far as I know. Even if you upload a logo on a test site and look at the resulting code, the path to the image source isn't there, so there's no way to pass on a default. I think we should still proceed with patterns that include logos nonetheless.
@onuro could you elaborate on what you mean by that? |
I updated the code because I realized the nav menu wasn't centred. |
Published! |
https://dotcompatterns.wordpress.com/?p=5579&preview=true
The text was updated successfully, but these errors were encountered: