Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centered header #210

Closed
alaczek opened this issue Jul 19, 2022 · 6 comments
Closed

Centered header #210

alaczek opened this issue Jul 19, 2022 · 6 comments

Comments

@alaczek
Copy link
Contributor

alaczek commented Jul 19, 2022

image

<!-- wp:group {"align":"full","style":{"spacing":{"padding":{"top":"2em","bottom":"4em"}}}} -->
<div class="wp-block-group alignfull" style="padding-top:2em;padding-bottom:4em"><!-- wp:site-logo {"align":"center"} /-->

<!-- wp:site-title {"textAlign":"center","fontSize":"large"} /-->

<!-- wp:navigation {"layout":{"type":"flex","justifyContent":"center"}} /--></div>
<!-- /wp:group -->

https://dotcompatterns.wordpress.com/?p=5579&preview=true

@iamtakashi
Copy link
Contributor

I think It'd be helpful for users to see the placeholder-looking logo for a header pattern like this. Can we add this image as the logo in the pattern?

https://headerandfooterpatterns.files.wordpress.com/2022/01/ba5d5-site-logo.png

@iamtakashi
Copy link
Contributor

Can we add this image as the logo in the pattern?

Hmm... I'm actually not sure if adding a site logo to dotcompatterns through this pattern will actually help anything. Will it be blank for the site that doesn't have a logo anyway? I guess it's worth testing with this? :)

@onuro
Copy link

onuro commented Jul 19, 2022

+1 on this. I think we need to tinker on ways to demo content in patterns even if they're WP db based(content showing up only if you have logo/post/nav on your site etc).

@alaczek
Copy link
Contributor Author

alaczek commented Jul 26, 2022

Can we add this image as the logo in the pattern?

It's not possible as far as I know. Even if you upload a logo on a test site and look at the resulting code, the path to the image source isn't there, so there's no way to pass on a default. I think we should still proceed with patterns that include logos nonetheless.

I think we need to tinker on ways to demo content in patterns even if they're WP db based

@onuro could you elaborate on what you mean by that?

@alaczek
Copy link
Contributor Author

alaczek commented Jul 26, 2022

I updated the code because I realized the nav menu wasn't centred.

@alaczek
Copy link
Contributor Author

alaczek commented Aug 29, 2022

Published!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants