Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too few trials causes a day not to be included in supervisor summarize #81

Open
nohelix opened this issue Aug 26, 2023 · 1 comment
Open
Labels

Comments

@nohelix
Copy link
Collaborator

nohelix commented Aug 26, 2023

Issue

No row displayed in sup-summerize today for Red 2, Red 5 & Red6.

Expected Behavior

A line should be displayed for the run today.

❗ Assuming my note below is correct, then the correct Expected Behavior would be that the filter should only apply to Oddball files with less than 2 complete blocks, but see newly opened second issue.

Notes

Low trial count may explain why no run is showing up. I believe the issue is related to bugged performance on line 513.

dplyr::filter(! (stim_type == "train" & complete_block_count < 2)) %>%

The filter limiting on complete blocks should only be applying for oddball files. These guys are on gap_detection and have never been on Oddball. Maybe it needs to be an &&.

Reproduce

Missing lines.zip
Using the provided files, run supervisor-summarize.R (I have provided my second attempt at getting them included in supervisor.xlsx)
Note the top lines are for 8/24.
You can confirm the runs are in for those rats as the count table at the top shows Rxn | Sodium Salicylate | 08/26/2023 | 2
Additionally you can see they are in the 'Runs entered for today' & 'Single Rat History' using the Common lookups.R

@nohelix
Copy link
Collaborator Author

nohelix commented Aug 26, 2023

Teal 1 works.zip
My diagnosis may be entirely wrong given that Teal 1 who only has 16 trials (less than the 20 for 2 complete blocks) does have a row in the table for today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant