Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Fix on save doesn't work correctly #198

Closed
syerad opened this issue Feb 29, 2016 · 4 comments
Closed

Fix on save doesn't work correctly #198

syerad opened this issue Feb 29, 2016 · 4 comments

Comments

@syerad
Copy link

syerad commented Feb 29, 2016

Version

3.4.8

Issue

If the option Fix on save is enabled there is a wrong behaviour.
If the rule requireSpacesInsideParentheses is enabled and a file is beeing saved
the linter reverses the rule on every save action.
For example: (with spaces)

            $( '#history' ).val( maxValue );

After first save:

            $('#history').val(maxValue);

The spaces are gone

After another save:

            $( '#history' ).val( maxValue );

The spaces are there...

If there are lines with spaces and without spaces in a single file the spaces will
be removed respectively will be added on each save

@syerad
Copy link
Author

syerad commented Feb 29, 2016

Maybe it is the same Issue like #197

@syerad
Copy link
Author

syerad commented Feb 29, 2016

I will try to use a different preset than airbnb and test if the wrong behavior remains

@syerad
Copy link
Author

syerad commented Mar 1, 2016

With some presets the problem occurs, with others it doesn't occurs. I think the problem is the rule requireSpacesInsideParentheses.

@Arcanemagus
Copy link
Member

This definitely looks like it's the same issue as #197, I'll close this for now and if it's still a problem when that gets fixed we can re-open this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants