From 80e92bb7038213d4015f05c95ae720494b266796 Mon Sep 17 00:00:00 2001
From: Dino Pacandi <dino.pacandi@gmail.com>
Date: Wed, 5 Feb 2025 15:07:35 +0100
Subject: [PATCH] Cleanup & benchmarks

---
 pallets/dapp-staking/src/benchmarking/mod.rs | 16 ++++++++++++++++
 pallets/dapp-staking/src/types.rs            |  2 +-
 precompiles/dapp-staking/src/test/mock.rs    |  2 +-
 3 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/pallets/dapp-staking/src/benchmarking/mod.rs b/pallets/dapp-staking/src/benchmarking/mod.rs
index c8ec3ddef9..972627bcaf 100644
--- a/pallets/dapp-staking/src/benchmarking/mod.rs
+++ b/pallets/dapp-staking/src/benchmarking/mod.rs
@@ -1137,6 +1137,22 @@ mod benchmarks {
         );
     }
 
+    #[benchmark]
+    fn set_static_tier_params() {
+        initial_config::<T>();
+
+        let mut tier_params = StaticTierParams::<T>::get();
+        assert!(tier_params.is_valid(), "Sanity check");
+
+        // Modify them so they aren't the same anymore
+        tier_params.reward_portion[0] = Permill::zero();
+
+        #[extrinsic_call]
+        _(RawOrigin::Root, tier_params.clone());
+
+        assert_eq!(StaticTierParams::<T>::get(), tier_params);
+    }
+
     impl_benchmark_test_suite!(
         Pallet,
         crate::benchmarking::tests::new_test_ext(),
diff --git a/pallets/dapp-staking/src/types.rs b/pallets/dapp-staking/src/types.rs
index 916f309177..753a6b0e0e 100644
--- a/pallets/dapp-staking/src/types.rs
+++ b/pallets/dapp-staking/src/types.rs
@@ -1535,7 +1535,7 @@ impl TierThreshold {
     CloneNoBound,
     TypeInfo,
 )]
-#[scale_info(skip_type_params(NT, SN))]
+#[scale_info(skip_type_params(NT))]
 pub struct TierParameters<NT: Get<u32>> {
     /// Reward distribution per tier, in percentage.
     /// First entry refers to the first tier, and so on.
diff --git a/precompiles/dapp-staking/src/test/mock.rs b/precompiles/dapp-staking/src/test/mock.rs
index 8a1672f425..1e1cb9a4e5 100644
--- a/precompiles/dapp-staking/src/test/mock.rs
+++ b/precompiles/dapp-staking/src/test/mock.rs
@@ -44,7 +44,7 @@ use astar_primitives::{
     dapp_staking::{
         CycleConfiguration, EraNumber, PeriodNumber, SmartContract, StakingRewardHandler,
         StandardTierSlots, STANDARD_TIER_SLOTS_ARGS,
-    }, 
+    },
     oracle::PriceProvider,
     AccountId, Balance, BlockNumber,
 };