Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include gameplay rules #5

Closed
Danfro opened this issue Feb 10, 2019 · 6 comments
Closed

include gameplay rules #5

Danfro opened this issue Feb 10, 2019 · 6 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed translation Translations are missing
Milestone
Farkle 1.0

Comments

@Danfro
Copy link
Contributor

Danfro commented Feb 10, 2019

it would be useful to include gameplay rules within the game so one can look them up rather than reading through the repo on github
Maybe they can be included under "about farkle"
@Arc676 Arc676 added the good first issue Good for newcomers label Feb 10, 2019
@Arc676 Arc676 added this to the Farkle 1.0 milestone Feb 10, 2019
@Arc676
Copy link
Owner

Arc676 commented Feb 16, 2019

Closed for German with #7; translation of the rules in other languages not yet completed.

@Arc676 Arc676 added help wanted Extra attention is needed translation Translations are missing good first issue Good for newcomers and removed good first issue Good for newcomers labels Feb 16, 2019
@Arc676
Copy link
Owner

Arc676 commented Mar 2, 2019 •
edited
Loading

Translations for the rest of the app are available in the following languages

  • Spanish
  • French
    For consistency, translations should be added for gameplay rules in these languages too.

@Danfro
Copy link
Contributor Author

Danfro commented Apr 4, 2019

If you do not get everything translated you could issue a new version. Maybe someone playing Farkle will help translating...

@Arc676
Copy link
Owner

Arc676 commented Apr 4, 2019 •
edited
Loading

I definitely intend to release a new version in the near future. I really want to get sound effects working in the next release though (#6).

EDIT: Immediately after writing this though, upon testing, sound effects work on mobile, just not on desktop. So I will definitely be publishing the next release within the next few days. Thanks for the reminder!

@Danfro
Copy link
Contributor Author

Danfro commented Apr 4, 2019

Of course that's great then, if you have some dev work going on. I just was curious if you only did not release a new version because you where waiting for those translations. 😏

If it was just me, I always turn off sound effects. 😄
But I am sure lots of others are going to like it!
Although sound seems not to be an easy thing to get flawless working... Good luck!

@Arc676
Copy link
Owner

Arc676 commented Apr 6, 2019

Closing this issue as the core issue has been addressed. Now tracking the Spanish translation's progress in #11.

@Arc676 Arc676 closed this as completed Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed translation Translations are missing
Projects
None yet
Milestone
Farkle 1.0
Development

No branches or pull requests
2 participants
@Arc676 @Danfro