Udp without control socket #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cail
commented
Sep 3, 2019
| @@ -295,6 +295,8 @@ struct iperf_test | |||
| char *remote_congestion_used; /* what the other side used */ | |||
| char *pidfile; /* -P option */ | |||
|
|
|||
| unsigned int delay; /* --delay server delay*/ | |||
There was a problem hiding this comment.
Why this is here? thats separate feature.
| @@ -330,6 +332,7 @@ struct iperf_test | |||
| int repeating_payload; /* --repeating-payload */ | |||
| int multithread; /* --multithread option */ | |||
| int thread_affinity; /* --thread-affinity option. Use only with --multithread option */ | |||
| int force_udp; /* --force-udp option - witnout answer*/ | |||
There was a problem hiding this comment.
bad name. suggest --no-server (int no_server_udp)
| if ((test->ctrl_sck < 0)) { | ||
| i_errno = IECONNECT; | ||
| return -1; | ||
| } | ||
|
|
||
| if (Nwrite(test->ctrl_sck, test->cookie, COOKIE_SIZE, Ptcp) < 0) { |
There was a problem hiding this comment.
you should scan on all the code and exclude ctrl_sck logic if !ctrl_sck
| #if defined(HAVE_SO_MAX_PACING_RATE) | ||
| " --fq-rate #[KMG] enable fair-queuing based socket pacing in\n" | ||
| " bits/sec (Linux only)\n" | ||
| " bits/sec (Linux only)\n" |
|
@WerWebWer plz fix the comments. And clarify why not stats output is happening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow udp to be generated even if no server available.