Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finality Voting Threshold metrics for alerting #323

Closed
bhazzard opened this issue Jun 27, 2024 · 3 comments
Closed

Finality Voting Threshold metrics for alerting #323

bhazzard opened this issue Jun 27, 2024 · 3 comments
Labels
discussion enhancement New feature or request

Comments

@bhazzard
Copy link

bhazzard commented Jun 27, 2024

Observability and alerting will be important to allow production network operators to remediate when voting falls below a threshold that will allow finality to advance.

To this end, Node Operators need a way to configure alerts that fire when finality voting falls below a configurable threshold.

Suggested Metrics:

  • number votes that should have been included in the block (using knowledge of schedule changes)
  • number of votes that were actually included in the block

This issue is related to #227

@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Jun 27, 2024
@bhazzard bhazzard added enhancement New feature or request discussion and removed triage labels Jun 27, 2024
@bhazzard bhazzard changed the title Finality Voting Threshold alerting metrics in Prometheus Finality Voting Threshold metrics for alerting Jun 27, 2024
@bhazzard
Copy link
Author

Potentially also: per finalizer, total delta time between block time and vote time.

This would give a picture of how long it takes for each finalizer to vote after a block is produced.

@bhazzard
Copy link
Author

bhazzard commented Jun 27, 2024

Decision needed: should we add this to Prometheus or Debug logs, or both?

@bhazzard bhazzard added this to the Savanna: Cusp milestone Jul 1, 2024
@arhag
Copy link
Member

arhag commented Aug 8, 2024

The logs already provide the above information and more.

Moreover, we now have a new endpoint (see #453) that provides useful information about the last votes by each finalizer which can more easily be used to build alerting tools to alert if some finalizers are failing to participate.

So I think we can close this issue.

@arhag arhag closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Team Backlog Aug 8, 2024
@arhag arhag removed this from the Spring v1.0.0 Cusp milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

3 participants