Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.0-rc2: gelf logging is busted when using dns pointing to both IPv4 and IPv6 addresses #900

Closed
matthewdarwin opened this issue Mar 25, 2023 · 3 comments · Fixed by #940
Assignees
Labels
actionable bug Something isn't working 👍 lgtm OCI Work exclusive to OCI team

Comments

@matthewdarwin
Copy link

matthewdarwin commented Mar 25, 2023

Upgrading a nodeos 3.2.2 node to 4.0.0-rc2 and enabling the prometheus plugin, the gelf logging shows now output with

$ tcpdump udp port 12201

Probably prometheus has no impact, but that was the only config change made.

logging.json was unchanged, which in part has this:

    {
      "name": "net",
      "type": "gelf",
      "args": {
        "endpoint": "prod-server:12201",
        "host": "jungle4-bp203",
        "_operator": "eosnationftw",
        "_network": "jungle4"
      },
      "enabled": true
    },
    {
      "name": "test",
      "type": "gelf",
      "args": {
        "endpoint": "test-server:12201",
        "host": "jungle4-bp203",
        "_operator": "eosnationftw",
        "_network": "jungle4"
      },
      "enabled": true
    }

...

    {
      "name": "transaction_failure_tracing",
      "level": "debug",
      "enabled": true,
      "additivity": false,
      "appenders": [
        "net",
        "test"
      ]
    },
    {
      "name": "transaction_success_tracing",
      "level": "debug",
      "enabled": true,
      "additivity": false,
      "appenders": [
        "net",
        "test"
      ]
    }
@heifner heifner added bug Something isn't working actionable and removed triage labels Mar 25, 2023
@matthewdarwin
Copy link
Author

Works with IP address, but not DNS which resolves to both IPv4 and IPv6 address.

@heifner
Copy link
Member

heifner commented Mar 25, 2023

Need to remove the use of libfc udp_socket which is hard coded to use IPv4 only. gelf_appender should use boost directly. That should have been done as part of moving gelf to another thread: #650 (comment)

@matthewdarwin matthewdarwin changed the title 4.0.0-rc2: gelf logging is busted 4.0.0-rc2: gelf logging is busted when using dns pointing to both IPv4 and IPv6 addresses Mar 25, 2023
@spoonincode
Copy link
Member

yes that clean up should have been done, but worst case to resolve this issue quickly in 4.0 can simply change the resolver to v4 only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actionable bug Something isn't working 👍 lgtm OCI Work exclusive to OCI team
Projects
Archived in project
6 participants