Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: use EOS VM's WASM parser with EOS VM OC #673

Open
spoonincode opened this issue Jan 30, 2023 · 1 comment
Open

Refactor: use EOS VM's WASM parser with EOS VM OC #673

spoonincode opened this issue Jan 30, 2023 · 1 comment

Comments

@spoonincode
Copy link
Member

EOS VM OC needs to be refactored to use EOS VM's WASM parser. This will allow commonality between the two implementations and is probably tech debt number one for EOS VM OC.

This is a carryover of eosnetworkfoundation/mandel#640 however I have dropped the discussion about wholesale removal of WAVM's wasm parser. It's not clear that is the correct approach: prior to CONFIGURABLE_WASM_LIMITS2 I believe WAVM's parser is always clutched in in front of EOS VM's parser. We may want to maintain that behavior indefinitely just to ensure we don't goof up something. Leaving WAVM's parser in the code indefinitely doesn't seem too high overhead.

@spoonincode
Copy link
Member Author

Completely remove WASM::check_limits as part of this, see #969

@BenjaminGormanPMP BenjaminGormanPMP added this to the Leap v5.0.0-rc1 milestone Jul 6, 2023
@bhazzard bhazzard removed this from the Leap v5.0.0-rc1 Critical milestone Sep 19, 2023
@bhazzard bhazzard changed the title refactor EOS VM OC to use EOS VM's WASM parser Refactor: use EOS VM's WASM parser with EOS VM OC Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

5 participants