Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update http-max-bytes-in-flight-mb description #47

Closed
heifner opened this issue Aug 25, 2022 · 3 comments
Closed

Update http-max-bytes-in-flight-mb description #47

heifner opened this issue Aug 25, 2022 · 3 comments
Assignees
@linh2931
Milestone
Leap 3.1.0

Comments

@heifner
Copy link
Member

heifner commented Aug 25, 2022

http-max-bytes-in-flight-mb

The comment in the default config is wrong, it returns 429, not 503 when exceeding the limit.

# Maximum size in megabytes http_plugin should use for processing http requests. 503 error response when exceeded. (eosio::http_plugin)

Originally posted by @matthewdarwin in #46 (comment)
@heifner
Copy link
Member Author

heifner commented Aug 25, 2022

websocketpp::http::status_code::too_many_requests == 429. The description is wrong.

@stephenpdeos stephenpdeos moved this to Todo in Team Backlog Aug 25, 2022
@linh2931 linh2931 self-assigned this Aug 26, 2022
@linh2931 linh2931 moved this from Todo to In Progress in Team Backlog Aug 26, 2022
@linh2931
Copy link
Member

This problem was fixed on main branch by eosnetworkfoundation/mandel#561.

@linh2931 linh2931 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 26, 2022
Repository owner moved this from In Progress to Done in Team Backlog Aug 26, 2022
@linh2931 linh2931 reopened this Aug 27, 2022
@linh2931 linh2931 moved this from Done to In Progress in Team Backlog Aug 27, 2022
@linh2931 linh2931 added this to the Leap 3.1.0 milestone Aug 27, 2022
@linh2931 linh2931 mentioned this issue Aug 27, 2022
Merged
@linh2931 linh2931 moved this from In Progress to Awaiting Review in Team Backlog Aug 27, 2022
@linh2931 linh2931 modified the milestones: Leap 3.1.0, Leap 3.2.0-rc1 Aug 27, 2022
@linh2931
Copy link
Member

On release 3.1 branch, the problem was fixed by #63.

Repository owner moved this from Awaiting Review to Done in Team Backlog Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linh2931 linh2931

Labels
None yet
Projects
Team Backlog
Archived in project
Milestone
Leap 3.1.0
Development

No branches or pull requests
2 participants
@heifner @linh2931