Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Remove chain_pacemaker and qc_chain related files and code #2123

Closed
linh2931 opened this issue Jan 22, 2024 · 1 comment · Fixed by #2146
Closed

IF: Remove chain_pacemaker and qc_chain related files and code #2123

linh2931 opened this issue Jan 22, 2024 · 1 comment · Fixed by #2146
Assignees
@linh2931
Labels
👍 lgtm
Milestone
Leap v6.0.0-rc1

Comments

@linh2931
Copy link
Member

linh2931 commented Jan 22, 2024 •
edited
Loading

chain_pacemaker.(hpp/cpp) and qc_chain.(hpp/cpp) are no longer needed. Remove them to save maintenance.

Ensure tests using qc_chain and chain_pacemaker have been ported to work with the new implementation.

As it is a significant work to port the large number of the tests, #2147 is created to track the work.
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Jan 22, 2024
@arhag
Copy link
Member

arhag commented Jan 22, 2024

Also avoid using hotstuff in the code. And prefer using just finality rather than instant_finality if possible.

@arhag arhag added 👍 lgtm and removed triage labels Jan 22, 2024
@arhag arhag mentioned this issue Jan 22, 2024
Closed
@arhag arhag assigned fcecin and linh2931 and unassigned fcecin Jan 22, 2024
@linh2931 linh2931 mentioned this issue Jan 26, 2024
Merged
@linh2931 linh2931 moved this from Todo to In Progress in Team Backlog Jan 26, 2024
@linh2931 linh2931 mentioned this issue Jan 26, 2024
Closed
@linh2931 linh2931 moved this from In Progress to Done in Team Backlog Jan 29, 2024
@linh2931 linh2931 linked a pull request Jan 29, 2024 that will close this issue
IF: remove chain_pacemaker and qc_chain related files #2146
Merged
@BenjaminGormanPMP BenjaminGormanPMP added this to the Leap v6.0.0-rc1 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linh2931 linh2931

Labels
👍 lgtm
Projects
Team Backlog
Archived in project
Milestone
Leap v6.0.0-rc1
Development

Successfully merging a pull request may close this issue.

IF: remove chain_pacemaker and qc_chain related files AntelopeIO/leap
5 participants
@fcecin @arhag @linh2931 @enf-ci-bot @BenjaminGormanPMP