Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Update BLS integration to use HotStuff version from main #1509

Closed
Tracked by #1508
arhag opened this issue Aug 17, 2023 · 1 comment · Fixed by #1527
Closed
Tracked by #1508

IF: Update BLS integration to use HotStuff version from main #1509

arhag opened this issue Aug 17, 2023 · 1 comment · Fixed by #1527
Assignees
@fcecin @heifner
Labels
👍 lgtm

Comments

@arhag
Copy link
Member

arhag commented Aug 17, 2023 •
edited
Loading

The current commit of the hotstuff_integration branch (https://github.com/AntelopeIO/leap/commits/005d500e7b9a29325be0fd253710a5fe205f1792) uses an old version of BLS code that has since been modified as part of the effort of merging the code into the main branch of Leap.

The hotstuff_integration branch should be changed to fix the discrepancy of BLS between the branch and main. Also additional immediate merge conflicts should be resolved.
@arhag arhag mentioned this issue Aug 17, 2023
Closed
@arhag arhag added 👍 lgtm and removed triage labels Aug 17, 2023
@bhazzard bhazzard changed the title HotStuff: Update BLS integration to use version from main IF: Update BLS integration to use HotStuff version from main Aug 17, 2023
@arhag arhag added this to the Leap v5.0.0-rc1 milestone Aug 17, 2023
@arhag arhag mentioned this issue Aug 17, 2023
Closed
@heifner heifner self-assigned this Aug 17, 2023
@BenjaminGormanPMP BenjaminGormanPMP moved this from Todo to In Progress in Team Backlog Aug 17, 2023
@heifner heifner mentioned this issue Aug 18, 2023
Merged
@heifner heifner linked a pull request Aug 18, 2023 that will close this issue
IF: Merge main into hotstuff_integration #1527
Merged
@heifner
Copy link
Member

heifner commented Aug 21, 2023

Completed by #1527

@heifner heifner closed this as completed Aug 21, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Aug 21, 2023
@arhag arhag removed this from the Leap v5.0.0-rc1 milestone Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fcecin fcecin

@heifner heifner

Labels
👍 lgtm
Projects
Team Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

IF: Merge main into hotstuff_integration AntelopeIO/leap
4 participants
@fcecin @heifner @arhag @enf-ci-bot