Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard Against crashes in HTTP when making addition nodeos calls #1372

Closed
ericpassmore opened this issue Jul 5, 2023 · 0 comments · Fixed by #1370
Closed

Guard Against crashes in HTTP when making addition nodeos calls #1372

ericpassmore opened this issue Jul 5, 2023 · 0 comments · Fixed by #1370
Assignees
Labels
bug Something isn't working 👍 lgtm

Comments

@ericpassmore
Copy link
Contributor

Don't crash when making calls to nodeos in service on an HTTP request. Interactions should be treated as suspect, and a failure should be returned to the client.

We talked with Guillaume. Turn out he was using a build from a fork which had pulled a version post 4.0.3 by mistake:
image

Checked client repo and indeed they had a change not in our release/4.0 branch, which causes the issue.

They will rebase their repo on the right tag (4.0.3) which will solve the issue for them.

The change causing the leap crash has not been released (it is in our main branch), and I have a fix for it. So in a sense the mistake they made was lucky for us, as it allowed us to catch the leap issue before the code was officially released.

To be 100% clear, no 4.0.x leap release is subject to the crash in http_plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 👍 lgtm
Projects
Archived in project
4 participants