From 26c61be91ff1fcdd931e97a943ba541fdbbaef3d Mon Sep 17 00:00:00 2001 From: Kevin Heifner Date: Thu, 21 Dec 2023 12:37:13 -0600 Subject: [PATCH] GH-1941 Avoid copy --- plugins/producer_plugin/producer_plugin.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/plugins/producer_plugin/producer_plugin.cpp b/plugins/producer_plugin/producer_plugin.cpp index d64884a2a4..f6676c5b5d 100644 --- a/plugins/producer_plugin/producer_plugin.cpp +++ b/plugins/producer_plugin/producer_plugin.cpp @@ -1788,7 +1788,7 @@ producer_plugin_impl::start_block_result producer_plugin_impl::start_block() { _pending_block_mode = pending_block_mode::producing; // Not our turn - const auto scheduled_producer = chain.active_producers().get_scheduled_producer(block_time); + const auto& scheduled_producer = chain.active_producers().get_scheduled_producer(block_time); const auto current_watermark = _producer_watermarks.get_watermark(scheduled_producer.producer_name); @@ -1947,11 +1947,12 @@ producer_plugin_impl::start_block_result producer_plugin_impl::start_block() { LOG_AND_DROP(); if (chain.is_building_block()) { - auto pending_block_signing_authority = chain.pending_block_signing_authority(); + const auto& pending_block_signing_authority = chain.pending_block_signing_authority(); + const auto& scheduled_producer_authority = chain.active_producers().get_scheduled_producer(block_time); - if (in_producing_mode() && pending_block_signing_authority != scheduled_producer.authority) { + if (in_producing_mode() && pending_block_signing_authority != scheduled_producer_authority.authority) { elog("Unexpected block signing authority, reverting to speculative mode! [expected: \"${expected}\", actual: \"${actual\"", - ("expected", scheduled_producer.authority)("actual", pending_block_signing_authority)); + ("expected", scheduled_producer_authority.authority)("actual", pending_block_signing_authority)); _pending_block_mode = pending_block_mode::speculating; }