From f991f2b4766b9f70920799a4fdb9d1f9cb75fa7f Mon Sep 17 00:00:00 2001 From: Anastasiia Sliusar Date: Thu, 29 Aug 2024 16:36:51 +0200 Subject: [PATCH] Rename parameter --- packages/apputils/src/sessioncontext.tsx | 8 ++++---- packages/apputils/test/sessioncontext.spec.ts | 2 +- packages/console-extension/src/index.ts | 6 +++--- packages/notebook-extension/src/index.ts | 4 ++-- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/packages/apputils/src/sessioncontext.tsx b/packages/apputils/src/sessioncontext.tsx index 4463d0046870..dccf0c4ec528 100644 --- a/packages/apputils/src/sessioncontext.tsx +++ b/packages/apputils/src/sessioncontext.tsx @@ -1914,8 +1914,8 @@ namespace Private { translator ); - const allowCustomEnvVariables = - PageConfig.getOption('allow_setup_custom_env_variables') === 'true' + const acceptKernelEnvVar = + PageConfig.getOption('accept_kernel_env_var') === 'true' ? true : false; const envVarsDiv = document.createElement('div'); @@ -1933,7 +1933,7 @@ namespace Private { option.selected = true; let val = JSON.parse(value); let id = val && val.id ? val.id : ''; - if (allowCustomEnvVariables && !id) { + if (acceptKernelEnvVar && !id) { let defaultEnvValue = {}; envVarsDiv.innerHTML = ''; addEnvBlock(envVarsDiv, defaultEnvValue, translator); @@ -1952,7 +1952,7 @@ namespace Private { let kernelData = JSON.parse(select.value) as Kernel.IModel; envVarsDiv.innerHTML = ''; body.setAttribute('data-custom-env-vars', ''); - if (allowCustomEnvVariables && !kernelData.id) { + if (acceptKernelEnvVar && !kernelData.id) { let defaultEnvValue = {}; addEnvBlock(envVarsDiv, defaultEnvValue, translator); } diff --git a/packages/apputils/test/sessioncontext.spec.ts b/packages/apputils/test/sessioncontext.spec.ts index e16ad3ba7665..19abe6a02845 100644 --- a/packages/apputils/test/sessioncontext.spec.ts +++ b/packages/apputils/test/sessioncontext.spec.ts @@ -71,7 +71,7 @@ describe('@jupyterlab/apputils', () => { // eslint-disable-next-line camelcase allow_external_kernels: true, // eslint-disable-next-line camelcase - allow_setup_custom_env_variables: true, + accept_kernel_env_var: true, // eslint-disable-next-line camelcase external_connection_dir: external } diff --git a/packages/console-extension/src/index.ts b/packages/console-extension/src/index.ts index 6d66359ae215..abdf3d0b67b8 100644 --- a/packages/console-extension/src/index.ts +++ b/packages/console-extension/src/index.ts @@ -446,11 +446,11 @@ async function activateConsole( }); } - const allowCustomEnvVariables = - PageConfig.getOption('allow_setup_custom_env_variables') === 'true' + const acceptKernelEnvVar = + PageConfig.getOption('accept_kernel_env_var') === 'true' ? true : false; - if (allowCustomEnvVariables) { + if (acceptKernelEnvVar) { app.contextMenu.addItem({ command: CommandIDs.setupCustomEnv, selector: '.jp-LauncherCard[data-category="Console"]', diff --git a/packages/notebook-extension/src/index.ts b/packages/notebook-extension/src/index.ts index bea181e4efb7..0119f848183a 100644 --- a/packages/notebook-extension/src/index.ts +++ b/packages/notebook-extension/src/index.ts @@ -2131,8 +2131,8 @@ function activateNotebookHandler( services.kernelspecs.specsChanged.connect(onSpecsChanged); }); - const allowCustomEnvVariables = - PageConfig.getOption('allow_setup_custom_env_variables') === 'true' + const acceptKernelEnvVar = + PageConfig.getOption('accept_kernel_env_var') === 'true' ? true : false; if (allowCustomEnvVariables) {