Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home page styles are slightly off #22

Open
2 of 8 tasks
thescientist13 opened this issue Nov 9, 2021 · 3 comments · Fixed by #40
Open
2 of 8 tasks

home page styles are slightly off #22

thescientist13 opened this issue Nov 9, 2021 · 3 comments · Fixed by #40
Labels
bounty:eligible bug Something isn't working help wanted Extra attention is needed

Comments

@thescientist13
Copy link
Contributor

thescientist13 commented Nov 9, 2021

Type of Change

  • New Feature Request
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

general home page styles don't match production

Screen Shot 2021-11-08 at 19 45 48

Screen Shot 2021-11-08 at 19 45 55

Details

It should look like this
Screen Shot 2021-11-08 at 19 45 12
Screen Shot 2021-11-08 at 19 45 20

This is likely due to do the migration from Bootstrap w/ SASS compilation to pre-compiled Bootstrap so things like
@include mixing and darken, transparentize functions mixin won't work anymore.

This likely accounts for, but will there are other tweaks needed as well

  • home page banner width
  • posts lists / events calendar height (bottom) not matching
  • posts lists / events calendar container width not as wide as banner
  • restore lint:css to top level lint task and fix stylelint warnings

Ideally would like to avoid any direct dependencies on SASS features specifically, even if it is a slight degradation in look / feel behavior.

@thescientist13
Copy link
Contributor Author

thescientist13 commented Nov 27, 2021

@aholtzman
Do you know if it would be hard to accomplish the last couple nips / ticks captured in #48 ? They are somewhat subtle but if they're a PITA to fix, I'm happy to close this out and apply that time to a more compelling issue, but if its easy to preserve design parity (or if there is a better design choice), would be good to know either way.

Thanks, let me know your thoughts!

@aholtzman
Copy link
Contributor

I was just chipping away at the larger styling issues as I had time. We could just make a PR per page/space to get things roughly in line/working then do an overall polish pr to harmonize the styles.

@thescientist13
Copy link
Contributor Author

cool, thanks and appreciate you helping out with overall polish, it definitely needs it for this migration! 🙏

It seems then between this issue and #42 , then that should keep us covered and on track so will this leave this open and on the punch list for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty:eligible bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants