Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling this.unsubscribe() twice #9

Open
markrickert opened this issue Nov 15, 2017 · 0 comments
Open

Calling this.unsubscribe() twice #9

markrickert opened this issue Nov 15, 2017 · 0 comments

Comments

@markrickert
Copy link
Contributor

Should there be a guard in place where calling this.unsubscribe() when there are no active listeners on the object? Calling it twice generates an error and it would be nice if the module remembered the state and didn't call it if it wasn't necessary.

Having this guard in place would eliminate a lot of code in my project that's checking this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant