Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we save assets locally to avoid request loading from server every time? #294

Closed
chaosprint opened this issue Apr 11, 2023 · 2 comments

Comments

@chaosprint
Copy link
Contributor

When calling asset::url
check if ~/Document/Ambient/GAME_NAME/content/assets/ASSET.FILE exist
if not, request it from the server

In future web version, we can use Web Storage API

related to this PR: #290

@chaosprint chaosprint changed the title Should we save the asset locally to avoid http request every time? Should we save assets locally to avoid request loading from server every time? Apr 11, 2023
@philpax
Copy link
Contributor

philpax commented Apr 11, 2023

Yes, we had this originally; we ended up disabling it because it would use the old versions of files instead of new files. The solution to this will probably involve #12.

@FredrikNoren
Copy link
Contributor

Like @philpax said, this already exists, but we need to implement cache invalidation: #81 Closing this issue in favour of that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants