Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates in ClickHouseKeeperInstallation are not used #1504

Closed
ShuaiShao93 opened this issue Sep 7, 2024 · 8 comments
Closed

Templates in ClickHouseKeeperInstallation are not used #1504

ShuaiShao93 opened this issue Sep 7, 2024 · 8 comments
Labels
Keeper ClickHouse Keeper issues

Comments

@ShuaiShao93
Copy link

It looks like there is no way to use the templates in https://github.com/Altinity/clickhouse-operator/blob/master/docs/chk-examples/02-extended-3-nodes.yaml#L26-L66, so specifying them is not useful.

I tried to add defaults but got

error validating data: ValidationError(ClickHouseKeeperInstallation.spec): unknown field "defaults" in com.altinity.clickhouse-keeper.v1.ClickHouseKeeperInstallation.spec
@Slach Slach added the Keeper ClickHouse Keeper issues label Sep 7, 2024
@Slach
Copy link
Collaborator

Slach commented Sep 7, 2024

@ShuaiShao93
Copy link
Author

This works, thank you! When will 0.24 go out formally?

@Slach
Copy link
Collaborator

Slach commented Sep 7, 2024

we don't provide any ETA
kind: ClickHouseInstallationKeeper now in deep refactoring

@Slach Slach closed this as completed Sep 7, 2024
@ShuaiShao93
Copy link
Author

ShuaiShao93 commented Sep 19, 2024

@Slach the ClickHouseInstallationKeeper works for some cluster, but exactly the same manifest doesn't work for another cluster for some reason. Looks like the defaults didn't take effect. I'm testing different kubernetes versions to figure out why, but do you have any thoughts why this may happen?

$ kubectl describe sts clickhouse-keeper
Name:               clickhouse-keeper
Namespace:          default
CreationTimestamp:  Wed, 18 Sep 2024 18:21:58 -0700
Selector:           app=clickhouse-keeper,uid=ce5c0680-c64e-43db-8b6a-e7416642b1f2
Labels:             app=clickhouse-keeper
                    uid=ce5c0680-c64e-43db-8b6a-e7416642b1f2
Annotations:        <none>
Replicas:           3 desired | 0 total
Update Strategy:    RollingUpdate
Pods Status:        0 Running / 0 Waiting / 0 Succeeded / 0 Failed
Pod Template:
  Labels:  app=clickhouse-keeper
           uid=ce5c0680-c64e-43db-8b6a-e7416642b1f2
  Containers: <none>
  Volumes:      <none>
Volume Claims:  <none>
Events:
  Type     Reason        Age                   From                    Message
  ----     ------        ----                  ----                    -------
  Warning  FailedCreate  31s (x17 over 5m58s)  statefulset-controller  create Pod clickhouse-keeper-0 in StatefulSet clickhouse-keeper failed error: Pod "clickhouse-keeper-0" is invalid: spec.containers: Required value

@Slach
Copy link
Collaborator

Slach commented Sep 19, 2024

@ShuaiShao93 which is your kubernetes version?

@ShuaiShao93
Copy link
Author

@ShuaiShao93 which is your kubernetes version?

Yeah I figured this out. The keeper 0.24.0 requires at least kubernetes 1.29. After upgrading, it works now. Thanks!

@zz913922
Copy link

zz913922 commented Jan 3, 2025

I encountered the same issue, and our cluster can't be upgraded to v1.29 easily.

After I modified the generated statefulset, the chi CRD object won't reconcile successfully

@zz913922
Copy link

zz913922 commented Jan 3, 2025

Sorry my mistake, didn't fill in the spec.defaults.templates.podTemplate name correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Keeper ClickHouse Keeper issues
Projects
None yet
Development

No branches or pull requests

3 participants