Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded cluster.local DNS suffix for Clickhouse Keeper #1459

Closed
hmerat opened this issue Jul 18, 2024 · 2 comments
Closed

Hardcoded cluster.local DNS suffix for Clickhouse Keeper #1459

hmerat opened this issue Jul 18, 2024 · 2 comments
Labels
Keeper ClickHouse Keeper issues

Comments

@hmerat
Copy link

hmerat commented Jul 18, 2024

Hi! Clickhouse keeper from clickhouse-operator doesn't work because of hardcoded cluster.local suffix. In our k8s installation we use custom domain name, which differs from cluster.local

For Clickhouse, we can override this by using namespaceDomainPattern but this options seems not available for Clickhouse Keeper.

Thanks.

@minor-fixes
Copy link

I'm running into this too - it looks like namespaceDomainPattern is added to the CRD for keeper installations by this commit, but it is not actually respected, and there are hardcoded .svc.cluster.local throughout the codebase.

@alex-zaitsev alex-zaitsev added the Keeper ClickHouse Keeper issues label Aug 15, 2024
@Slach
Copy link
Collaborator

Slach commented Sep 9, 2024

@minor-fixes could you try clickhouse-operator:0.24.0 ?

I checked

minikube start --dns-domain=custom.k8s.local

install operator
then applied

apiVersion: "clickhouse-keeper.altinity.com/v1"
kind: "ClickHouseKeeperInstallation"
metadata:
  name: simple1
spec:
  namespaceDomainPattern: "%s.svc.custom.k8s.local"
  configuration:
    clusters:
      - name: "cluster1"
        replicas: 3

@Slach Slach closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Keeper ClickHouse Keeper issues
Projects
None yet
Development

No branches or pull requests

4 participants