Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate Service instead of Patch for some changes (ClusterIP -> NodePort) #1302

Closed
UnamedRus opened this issue Jan 5, 2024 · 4 comments
Closed

Comments

@UnamedRus
Copy link

For example, when people want to change ClusterIP service to NodePort, it produce incorrect configuration.

WA is manually remove ClusterIP service and reconcile CHI.

kubernetes/kubernetes#24040

@sunsingerus
Copy link
Collaborator

More info required. Proposed logic is already implemented in service reconciler
In case operator is unable to update the service, it is recreated via delete+create. So there is either no error on update or situation needs additional clarification

@UnamedRus
Copy link
Author

In case operator is unable to update the service,

It seems, there is no problem with update of service definition itself. it's succeed.

Problem is that result definition is incorrect for code, which use this definition.

@sunsingerus
Copy link
Collaborator

Well, we can go as just recreate the service in case of service type change

@alex-zaitsev
Copy link
Member

Fixed in 0.23.0, covered by test_012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants