Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Exchange - Beta Checklist #488

Closed
4 of 7 tasks
Zidane opened this issue Aug 24, 2018 · 0 comments
Closed
4 of 7 tasks

[Feature] Exchange - Beta Checklist #488

Zidane opened this issue Aug 24, 2018 · 0 comments

Comments

@Zidane
Copy link
Member

Zidane commented Aug 24, 2018

Exchange is getting close to prime time for inclusion into the Almura mod for a time and released to the masses at a later date. In the interim, the following is a rough TODO before I'll sign it off for beta candidacy.

  • Finish up notification TODOs in ServerExchangeManager.
  • Handle "refund" if database insertion fails when listing a new item. I'll need to give it back to their inventory. If we cannot give them all of the item, alert the console and the admin and the player can sort it out.
  • Handle giving them the items back after purchase if they went offline. If we cannot give them all of the item, alert the console and the admin and the player can sort it out.
  • Change purchase to deduct the cash right away from the buyer.
    • Once done, handle "refund" if database transaction fails. We need to refund the buyer their money.
  • Handle slot limit upgrades. Dockter is thinking a "step up" system via commands.
  • Rigorous testing. If bugs are found, I want clear and concise instructions on how to reproduce. The inventory logic in this mod is complex.
@Grinch Grinch changed the title Exchange Beta Checklist [Feature] Exchange - Beta Checklist Apr 21, 2020
@Dockter Dockter closed this as completed Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants