Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/create inputwidget for prediction outputs #582

Merged
merged 25 commits into from
Feb 13, 2025
Merged

Refactor/create inputwidget for prediction outputs #582

merged 25 commits into from
Feb 13, 2025

Conversation

yrkim98
Copy link
Collaborator

@yrkim98 yrkim98 commented Feb 4, 2025

Purpose

Replaces FileInputWidget in ThresholdingView with a PredictionResultInputWidget, which only allows you to select images that are the result of prediction during thresholding.

Changes

  • Created new PredictionResultInputWidget which only allows selection of images that are the result from training
  • changes to Viewer, ThresholdingView, ThresholdingService to support the above change.
  • Changes to variable names in ThresholdingService from comments on previous pr by @hughes036

Testing

Tested manually on Ec2 instance as well as on my windows machine at home.

How to review

Start with ThresholdingView, and see related changes in Viewer, ThresholdingView, ThresholdingService.
Lastly check out PredictionResultInputWidget and changes to FileInputModel which the PredictionResultInputWidget still uses.

yrkim98 added 22 commits January 29, 2025 10:32
@yrkim98
prediction_result_list_widget
20fd598
@yrkim98
need this still
980c050
@yrkim98
use imagedata
4147232
@yrkim98
oops, should be ImageData.np_data not ImageData.data
fc68eb8
@yrkim98
change way we insert a new segmentation threshold layer
33c003e
@yrkim98
prepend [threshold] to layer name only if this is the first time a th…
c7f13cd 
…reshold has been applied
@yrkim98
no key check for dictionary
ae26f80
@yrkim98
no key check for dictionary
0af12e6
@yrkim98
init prediction layers as empty- since for now we will not have any p…
92ba3fa 
…rediction layers on plugin startup
@yrkim98
dont store ImageData object, can just store np.data directly
a45fbb2
@yrkim98
black
f2889fb
@yrkim98
maintain previous selections
7586d8a
@yrkim98
instance not working correctly
a25cf4a
@yrkim98
threshold only selected layers
a598a88
@yrkim98
revert
c22520e
@yrkim98
only threshold selected idx
63cc313
@yrkim98
rename process checked singal function
e935624
@yrkim98
lint
148fa75
@yrkim98
use the correct layer instance
fe7d42c
@yrkim98
working
c56c302
@yrkim98
optional instead of none
80eaf0f
@yrkim98
changing function and varible names to use binary map/prob map
dec344e
smishra3
smishra3 approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@smishra3 smishra3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@yrkim98 yrkim98 merged commit 2eef549 into feature/thresholding Feb 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughes036 hughes036 hughes036 left review comments

@smishra3 smishra3 smishra3 approved these changes

@benjijamorris benjijamorris benjijamorris approved these changes

@saeliddp saeliddp Awaiting requested review from saeliddp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yrkim98 @hughes036 @smishra3 @benjijamorris